Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sorting for bank transactions #549

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Add sorting for bank transactions #549

merged 5 commits into from
Sep 20, 2023

Conversation

dphilipov
Copy link
Contributor

Related to #1588

Motivation and context

  • My initial solution was to sort the data on the front-end, but since the data is paginated, this sorts only the current page. This PR makes sure the sort details reach the query, thus sorting all bank transactions.

@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited
Loading

✅ Tests will run for this PR. Once they succeed it can be merged.

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Sep 18, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 18, 2023
igoychev
igoychev reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!
just please check if the frontend is always passing the sortBy and sortOrder or add some defaults like in the comment below

@dphilipov dphilipov requested a review from igoychev September 19, 2023 09:18
igoychev
igoychev approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@igoychev igoychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful!

@igoychev igoychev added the run tests Allows running the tests workflows for forked repos label Sep 19, 2023
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Sep 19, 2023
@igoychev igoychev merged commit f307b74 into podkrepi-bg:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoychev igoychev igoychev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dphilipov @igoychev